-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eslint config #5720
Fix eslint config #5720
Conversation
@Latropos done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your change!
Are you sure, that all the rules (especially our custom one) keep working? The newest eslint v9 introduced some breaking changes.
Also probably in the future we will have to migrate to newer config format.
@Latropos you were right, I actually had to downgrade it to ESlint 8 due to breaking changes 馃ぃ |
Summary
Because we use ESlint rules that require a parses, proper amendments to the
.eslintrc.js
had to be made. Because of that we can also finally extend main.eslintrc.js
config in sub-directiories.You can read more here.
As a note, I recommend
eslint --print-config <file>
to debug if the rules are actually extended etc.Test plan
馃殌